Add settings and theme options #442
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [@rollup/rollup-linux-x64-gnu](https://github.com/rollup/rollup) from 4.54.0 to 4.55.1. - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](rollup/rollup@v4.54.0...v4.55.1) --- updated-dependencies: - dependency-name: "@rollup/rollup-linux-x64-gnu" dependency-version: 4.55.1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [@xterm/xterm](https://github.com/xtermjs/xterm.js) from 5.5.0 to 6.0.0. - [Release notes](https://github.com/xtermjs/xterm.js/releases) - [Commits](xtermjs/xterm.js@5.5.0...6.0.0) --- updated-dependencies: - dependency-name: "@xterm/xterm" dependency-version: 6.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [focus-trap](https://github.com/focus-trap/focus-trap) from 7.7.0 to 7.7.1. - [Release notes](https://github.com/focus-trap/focus-trap/releases) - [Changelog](https://github.com/focus-trap/focus-trap/blob/master/CHANGELOG.md) - [Commits](focus-trap/focus-trap@v7.7.0...v7.7.1) --- updated-dependencies: - dependency-name: focus-trap dependency-version: 7.7.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…m_and_yarn/focus-trap-7.7.1 Bump focus-trap from 7.7.0 to 7.7.1
…m_and_yarn/xterm/xterm-6.0.0 Bump @xterm/xterm from 5.5.0 to 6.0.0
…m_and_yarn/rollup/rollup-linux-x64-gnu-4.55.1 Bump @rollup/rollup-linux-x64-gnu from 4.54.0 to 4.55.1
Collaborator
Author
|
Some screenshots: |
Member
|
Please include a description of the changes in the PR itself. That way it'll be in the merge commit. Issue numbers are good to have but not enough on their own. Thanks! |
Collaborator
Author
|
Good point. Updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a settings dialog that can be used to easily add new settings. The settings are persistent and are loaded at runtime. Currently I have added a theme setting.
This also includes changes to allow theming such as reorganizing the color-related CSS. I have created a light theme and if there's something I missed (e.g. light text on light background), we can always update it.
This adds features for the following issues:
#181, #354, #355